Commit 04dae5a0 authored by Howard Chu's avatar Howard Chu
Browse files

ITS#4442 just log refint failures, client only cares about main request

parent 582ee967
...@@ -468,8 +468,8 @@ refint_response( ...@@ -468,8 +468,8 @@ refint_response(
for(ip = id->attrs, ac = 0; ip; ip = ip->next, ac++); for(ip = id->attrs, ac = 0; ip; ip = ip->next, ac++);
if(!ac) { if(!ac) {
rs->sr_err = LDAP_OTHER; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "refint_response called without any attributes"; "refint_response called without any attributes\n", 0, 0, 0 );
return SLAP_CB_CONTINUE; return SLAP_CB_CONTINUE;
} }
...@@ -483,13 +483,15 @@ refint_response( ...@@ -483,13 +483,15 @@ refint_response(
if(nop.o_bd) { if(nop.o_bd) {
if (!nop.o_bd->be_search || !nop.o_bd->be_modify) { if (!nop.o_bd->be_search || !nop.o_bd->be_modify) {
rs->sr_err = LDAP_UNWILLING_TO_PERFORM; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "backend missing search and/or modify"; "refint_response: backend missing search and/or modify\n",
0, 0, 0 );
return SLAP_CB_CONTINUE; return SLAP_CB_CONTINUE;
} }
} else { } else {
rs->sr_err = LDAP_OTHER; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "no known backend? this shouldn't be happening!"; "refint_response: no backend for our baseDN %s??\n",
id->dn.bv_val, 0, 0 );
return SLAP_CB_CONTINUE; return SLAP_CB_CONTINUE;
} }
...@@ -580,15 +582,17 @@ refint_response( ...@@ -580,15 +582,17 @@ refint_response(
dd.nnewdn.bv_val = NULL; dd.nnewdn.bv_val = NULL;
if(rc != LDAP_SUCCESS) { if(rc != LDAP_SUCCESS) {
rs->sr_err = nrs.sr_err; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "refint_response search failed"; "refint_response: search failed: %d\n",
rc, 0, 0 );
goto done; goto done;
} }
/* safety? paranoid just in case */ /* safety? paranoid just in case */
if(!cb.sc_private) { if(!cb.sc_private) {
rs->sr_err = LDAP_OTHER; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "whoa! refint_response callback wiped out sc_private?!"; "refint_response: callback wiped out sc_private?!\n",
0, 0, 0 );
goto done; goto done;
} }
...@@ -625,8 +629,9 @@ refint_response( ...@@ -625,8 +629,9 @@ refint_response(
nop.o_req_ndn = dp->dn; nop.o_req_ndn = dp->dn;
nop.o_bd = select_backend(&dp->dn, 0, 1); nop.o_bd = select_backend(&dp->dn, 0, 1);
if(!nop.o_bd) { if(!nop.o_bd) {
rs->sr_err = LDAP_OTHER; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "this should never happen either!"; "refint_response: no backend for DN %s!\n",
dp->dn.bv_val, 0, 0 );
goto done; goto done;
} }
nrs.sr_type = REP_RESULT; nrs.sr_type = REP_RESULT;
...@@ -637,8 +642,9 @@ refint_response( ...@@ -637,8 +642,9 @@ refint_response(
nop.o_ndn = nop.o_bd->be_rootndn; nop.o_ndn = nop.o_bd->be_rootndn;
if(rs->sr_err != LDAP_SUCCESS) goto done; if(rs->sr_err != LDAP_SUCCESS) goto done;
if((rc = nop.o_bd->be_modify(&nop, &nrs)) != LDAP_SUCCESS) { if((rc = nop.o_bd->be_modify(&nop, &nrs)) != LDAP_SUCCESS) {
rs->sr_err = nrs.sr_err; Debug( LDAP_DEBUG_TRACE,
rs->sr_text = "dependent modify failed"; "refint_response: dependent modify failed: %d\n",
nrs.sr_err, 0, 0 );
goto done; goto done;
} }
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment