We can't rlock if we've registered ourselves as a writer. We can only
figure that out by checking if we're the thread that initiated the
pause: is the server paused already?

Ondřej Kuzník authored Jan 18, 2023 and Quanah Gibson-Mount committed Jan 19, 2023

We're in a much better place now and there is only a single task active
for a given syncinfo_t plus the task that's just scheduled it and is
wrapping up. Any remaining times this wouldn't be true are probably bugs
to be fixed.

Ondřej Kuzník authored Jan 18, 2023 and Quanah Gibson-Mount committed Jan 19, 2023

epoch_append should be called at the point the object is not reachable
anymore, otherwise a thread from a "future" might still access it post
reclamation.

Use cn=config format of TRUE/FALSE instead of slapd.conf format on/off

Howard Chu authored Nov 22, 2022 and Quanah Gibson-Mount committed Dec 07, 2022

Same as ITS#9358 but for ordering matching rule, not just equality

Howard Chu authored Nov 03, 2022 and Quanah Gibson-Mount committed Dec 01, 2022

For simple (non-nested) member compares, avoid unnecessary fetches
of dyngroups that can't match the filter.
cache filter/entry instance info across multiple dyn entries to
avoid refetching each filter entry for each dyngruop test.

Howard Chu authored Oct 19, 2022 and Quanah Gibson-Mount committed Dec 01, 2022

Minimize cost of dynamic lists while still making them filterable:
require their attrs to be explicitly mapped if filtering is to be supported.

Also check config scope in compare op

Howard Chu authored Nov 24, 2022 and Quanah Gibson-Mount committed Dec 01, 2022

output buffer may overrun 1 byte for specially crafted approxMatch search filters.
Not exploitable, no operational or security impact.

fakepage pointers are only guaranteed to be 2-byte aligned. Use a
2-byte aligned struct definition when referencing 2-byte page members
if a page pointer possibly points to a fakepage.

32 was chosen for page size of 4KB. Not large nough for 16KB pages.

Ondřej Kuzník authored Oct 26, 2022 and Quanah Gibson-Mount committed Oct 31, 2022

config_back_entry_get currently returns the entry directly without
securing the rwlock, which is unsafe. However we can't keep holding it
on return in case the caller decides to hold onto the entry
indefinitely, hence rlock+entry_dup+runlock.

Ondřej Kuzník authored Oct 31, 2022 and Quanah Gibson-Mount committed Oct 31, 2022

Some values we export in cn=monitor are not managed in a single place,
instead, a task exists that gathers a snapshot of the lloadd state and
stores it for monitor consumption. This exposes a race between the test
reading it out and lloadd updating this cached copy. While we still have
to rely on a shell, rather than being intelligent about whether or not
we should emit a readout into search.out or wait and try again (which is
what test004-monitor does), just filter this attribute out.

ITS#9941 Fix asyncmeta manpage to clarify that only round-robin scheduling is used for target connections.

Add check for trivial input string.

Must dup arg since subtree may also come from parsed URL.

Harmless, length check at end of routine would have returned an
error anyway.

If a writer is blocked and a config pause is pending, just
close the blocked connection. Don't wait around for a slow
client to catch up.

Connor Smith authored Oct 03, 2022 and Quanah Gibson-Mount committed Oct 13, 2022

Use #elif defined(...) for HAVE_WINSOCK and MACOS. All other instances
of these macros use #ifdef or similar. A compiler may warn about them
not being defined.

In libraries/liblber/sockbuf.c, (DOS && PCNFS) and (DOS && NCSA) were
replaced with HAVE_PCNFS and HAVE_NCSA, respectively. It seems logical
to do the same at the only remaining occurrence of DOS, PCNFS, and NCSA.

Use #if HARDCODE_DATA consistently, replacing two instances of #ifdef.
HARDCODE_DATA is always defined, and this way you can set HARDCODE_DATA
to 0 and have it work, rather than it going down the wrong branch and
failing in these two cases.

Git doesn't recreate empty directories, make it explicitly