Commit d2b6e8d5 authored by Luke Howard's avatar Luke Howard
Browse files

Handle the case where slapi_x_ldapmods2modifications() returns NULL; the

modify request becomes a NOOP for the front-end in this case.
parent 92ac90c1
...@@ -361,6 +361,20 @@ do_modify( ...@@ -361,6 +361,20 @@ do_modify(
*/ */
slapi_pblock_get( pb, SLAPI_MODIFY_MODS, (void **)&modv ); slapi_pblock_get( pb, SLAPI_MODIFY_MODS, (void **)&modv );
modlist = slapi_x_ldapmods2modifications( modv ); modlist = slapi_x_ldapmods2modifications( modv );
/*
* NB: it is valid for the plugin to return no modifications
* (for example, a plugin might store some attributes elsewhere
* and remove them from the modification list; if only those
* attribute types were included in the modification request,
* then slapi_x_ldapmods2modifications() above will return
* NULL).
*/
if ( modlist == NULL ) {
rs->sr_err = LDAP_SUCCESS;
send_ldap_result( op, rs );
goto cleanup;
}
#endif /* defined( LDAP_SLAPI ) */ #endif /* defined( LDAP_SLAPI ) */
/* /*
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment