Commit f3952d94 authored by Ondřej Kuzník's avatar Ondřej Kuzník Committed by Quanah Gibson-Mount
Browse files

ITS#9059 Document why we do FIND_CSN

parent 709d805f
......@@ -2882,7 +2882,18 @@ no_change: if ( !(op->o_sync_mode & SLAP_SYNC_PERSIST) ) {
ldap_pvt_thread_mutex_unlock( &sl->sl_mutex );
}
}
/* Is the CSN still present in the database? */
/*
* If sessionlog wasn't useful, see if we can find at least one entry
* that hasn't changed based on the cookie.
*
* TODO: Using mincsn only (rather than the whole cookie) will
* under-approximate the set of entries that haven't changed, but we
* can't look up CSNs by serverid with the current indexing support.
*
* As a result, dormant serverids in the cluster become mincsns and
* more likely to make syncprov_findcsn(,FIND_CSN,) fail -> triggering
* an expensive refresh...
*/
if ( !do_present ) {
gotstate = 1;
} else if ( syncprov_findcsn( op, FIND_CSN, &mincsn ) != LDAP_SUCCESS ) {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment