Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Remove assert. This is merely a cache of parent DNs, failure to
insert doesn't affect outcome.

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

dn2id.c:
  + assertion for mdb_id2l_insert() result;
  - unnecessary assignment;

search.c:
  - unused variable 'first';
  + range-check for mdb_idl_search() result;

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

heap corruption due to returning a reference to a local variable

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Check for duplicate scopes in search_aliases, not later.

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

This reverts commit cac00c6a.

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Aliases pointing within the original search scope could cause
the same entry to be returned multiple times. Check for subtree
scope and duplicate scopes.

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Better check for missing IDs

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

mdb_idscopes was remembering the IDs of every entry it checked;
it should only have been saving the IDs of entries that were
actually in the search scope. The extra entries filled the scopes
array, causing a loop searching for a parent entry that was
never inserted.

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

uninit'd size in dn2id_walk, bogus pagedresults

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Non-recursive tree walker.

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

This is only a 10% gain, but still worth having for now.

Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

So they can be reused, and avoid unnecessary page_searches

Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Tighten up entry_alloc/entry_decode
Track parent nodes in idscopes

Hallvard Furuseth authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Also do not cast between berval and MDB_val.  That breaks when
sizeof(berval.bv_len) != sizeof(MDB_val.mv_size).