Skip to content
Snippets Groups Projects
Commit 6862cfd9 authored by Howard Chu's avatar Howard Chu
Browse files

Don't strdup conn->authz into op, just reference directly. (Conn cannot

be freed until after all associated ops are freed.)
parent c3ca53cd
Branches
Tags
No related merge requests found
......@@ -1555,13 +1555,11 @@ static int connection_op_activate( Connection *conn, Operation *op )
if (!arg->co_op->o_dn.bv_len) {
arg->co_op->o_authz = conn->c_authz;
arg->co_op->o_dn.bv_val = ch_strdup( conn->c_dn.bv_val ?
conn->c_dn.bv_val : "" );
arg->co_op->o_ndn.bv_val = ch_strdup( conn->c_ndn.bv_val ?
conn->c_ndn.bv_val : "" );
arg->co_op->o_dn = conn->c_dn;
arg->co_op->o_ndn = conn->c_ndn;
}
arg->co_op->o_authtype = conn->c_authtype;
ber_dupbv( &arg->co_op->o_authmech, &conn->c_authmech );
arg->co_op->o_authmech = conn->c_authmech;
if (!arg->co_op->o_protocol) {
arg->co_op->o_protocol = conn->c_protocol
......
......@@ -23,15 +23,6 @@ slap_op_free( Operation *op )
if ( op->o_ber != NULL ) {
ber_free( op->o_ber, 1 );
}
if ( op->o_dn.bv_val != NULL ) {
free( op->o_dn.bv_val );
}
if ( op->o_ndn.bv_val != NULL ) {
free( op->o_ndn.bv_val );
}
if ( op->o_authmech.bv_val != NULL ) {
free( op->o_authmech.bv_val );
}
if ( op->o_ctrls != NULL ) {
ldap_controls_free( op->o_ctrls );
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment