Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
O
OpenLDAP
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
François Kooman
OpenLDAP
Commits
8fb8b17c
Commit
8fb8b17c
authored
18 years ago
by
Kurt Zeilenga
Browse files
Options
Downloads
Patches
Plain Diff
Code which doesn't hanlding allocation failure should use
ch_ routines, not SLAP_ macros
parent
1b9d68d6
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
servers/slapd/back-ldif/ldif.c
+2
-2
2 additions, 2 deletions
servers/slapd/back-ldif/ldif.c
servers/slapd/referral.c
+3
-18
3 additions, 18 deletions
servers/slapd/referral.c
servers/slapd/result.c
+2
-10
2 additions, 10 deletions
servers/slapd/result.c
with
7 additions
and
30 deletions
servers/slapd/back-ldif/ldif.c
+
2
−
2
View file @
8fb8b17c
...
...
@@ -354,11 +354,11 @@ static int r_enum_tree(enumCookie *ck, struct berval *path,
}
else
{
/* Queueing up for tool mode */
if
(
ck
->
entries
==
NULL
)
{
ck
->
entries
=
(
Entry
**
)
SLAP_MALLOC
(
sizeof
(
Entry
*
)
*
ENTRY_BUFF_INCREMENT
);
ck
->
entries
=
(
Entry
**
)
ch_malloc
(
sizeof
(
Entry
*
)
*
ENTRY_BUFF_INCREMENT
);
ck
->
elen
=
ENTRY_BUFF_INCREMENT
;
}
if
(
ck
->
eind
>=
ck
->
elen
)
{
/* grow entries if necessary */
ck
->
entries
=
(
Entry
**
)
SLAP_REALLOC
(
ck
->
entries
,
sizeof
(
Entry
*
)
*
(
ck
->
elen
)
*
2
);
ck
->
entries
=
(
Entry
**
)
ch_realloc
(
ck
->
entries
,
sizeof
(
Entry
*
)
*
(
ck
->
elen
)
*
2
);
ck
->
elen
*=
2
;
}
...
...
This diff is collapsed.
Click to expand it.
servers/slapd/referral.c
+
3
−
18
View file @
8fb8b17c
...
...
@@ -108,12 +108,7 @@ static char * referral_dn_muck(
}
muck
.
bv_len
=
ntargetDN
.
bv_len
+
nrefDN
.
bv_len
-
nbaseDN
.
bv_len
;
muck
.
bv_val
=
SLAP_MALLOC
(
muck
.
bv_len
+
1
);
if
(
muck
.
bv_val
==
NULL
)
{
Debug
(
LDAP_DEBUG_ANY
,
"referral_dn_muck: SLAP_MALLOC failed
\n
"
,
0
,
0
,
0
);
return
NULL
;
}
muck
.
bv_val
=
ch_malloc
(
muck
.
bv_len
+
1
);
strncpy
(
muck
.
bv_val
,
ntargetDN
.
bv_val
,
ntargetDN
.
bv_len
-
nbaseDN
.
bv_len
);
...
...
@@ -217,12 +212,7 @@ BerVarray referral_rewrite(
return
NULL
;
}
refs
=
SLAP_MALLOC
(
(
i
+
1
)
*
sizeof
(
struct
berval
)
);
if
(
refs
==
NULL
)
{
Debug
(
LDAP_DEBUG_ANY
,
"referral_rewrite: SLAP_MALLOC failed
\n
"
,
0
,
0
,
0
);
return
NULL
;
}
refs
=
ch_malloc
(
(
i
+
1
)
*
sizeof
(
struct
berval
)
);
for
(
iv
=
in
,
jv
=
refs
;
!
BER_BVISNULL
(
iv
);
iv
++
)
{
LDAPURLDesc
*
url
;
...
...
@@ -292,12 +282,7 @@ BerVarray get_entry_referrals(
if
(
i
<
1
)
return
NULL
;
refs
=
SLAP_MALLOC
(
(
i
+
1
)
*
sizeof
(
struct
berval
));
if
(
refs
==
NULL
)
{
Debug
(
LDAP_DEBUG_ANY
,
"get_entry_referrals: SLAP_MALLOC failed
\n
"
,
0
,
0
,
0
);
return
NULL
;
}
refs
=
ch_malloc
(
(
i
+
1
)
*
sizeof
(
struct
berval
));
for
(
iv
=
attr
->
a_vals
,
jv
=
refs
;
iv
->
bv_val
!=
NULL
;
iv
++
)
{
unsigned
k
;
...
...
This diff is collapsed.
Click to expand it.
servers/slapd/result.c
+
2
−
10
View file @
8fb8b17c
...
...
@@ -83,11 +83,7 @@ static char *v2ref( BerVarray ref, const char *text )
}
}
v2
=
SLAP_MALLOC
(
len
+
i
+
sizeof
(
"Referral:"
)
);
if
(
v2
==
NULL
)
{
Debug
(
LDAP_DEBUG_ANY
,
"v2ref: SLAP_MALLOC failed"
,
0
,
0
,
0
);
return
NULL
;
}
v2
=
ch_malloc
(
len
+
i
+
sizeof
(
"Referral:"
)
);
if
(
text
!=
NULL
)
{
strcpy
(
v2
,
text
);
...
...
@@ -99,11 +95,7 @@ static char *v2ref( BerVarray ref, const char *text )
len
+=
sizeof
(
"Referral:"
);
for
(
i
=
0
;
ref
[
i
].
bv_val
!=
NULL
;
i
++
)
{
v2
=
SLAP_REALLOC
(
v2
,
len
+
ref
[
i
].
bv_len
+
1
);
if
(
v2
==
NULL
)
{
Debug
(
LDAP_DEBUG_ANY
,
"v2ref: SLAP_MALLOC failed"
,
0
,
0
,
0
);
return
NULL
;
}
v2
=
ch_realloc
(
v2
,
len
+
ref
[
i
].
bv_len
+
1
);
v2
[
len
-
1
]
=
'\n'
;
AC_MEMCPY
(
&
v2
[
len
],
ref
[
i
].
bv_val
,
ref
[
i
].
bv_len
);
len
+=
ref
[
i
].
bv_len
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment