Howard Chu authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

Using a hardcoded limit for now; no reasonable apps
should ever run into it.

Ryan Tandy authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

The defaults vary by crypto library and possibly even version, so it's
not worth trying to keep them accurate.

Peter Marschall authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

* use 'crypto_pwhash_str_alg(..., crypto_pwhash_ALG_ARGON2ID13)' to set
  the algorithm to Argon2.
  According to libsodium's documentation, the original 'crypto_pwhash_str()'
  only guarantees a "memory-hard, CPU-intensive hash function", but not
  necessarily Argon2.  Although in released versions of libsodium Argon2 is
  the only implemented backend, this may chane in the future.
* multiply the 'memory' parameter by 1024 to align it with the libargon2
  implementation. The objective is to have consistent configuration in
  OpenLDAP's pw-argon2 module no matter what backend implementation is used.

Signed-off-by: Peter Marschall <peter@adpm.de>

Ryan Tandy authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

Based on initial patch by Peter Marschall.

Peter Marschall authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

Add manual page slapd-pw-argon2.5 and make sure it gets installed.

Signed-off-by: Peter Marschall <peter@adpm.de>

Simon Levermann authored 8 years ago and Quanah Gibson-Mount committed 4 years ago

This change implements argon2, which won the Password Hashing
Competition (https://password-hashing.net/) as a contrib-module in order
to provide a modern password hashing alternative in openldap. The
currently available password hashing algorithms are relatively old, and
modern hardware, especially GPUs can compute quite a few (ranging from
tens of thousands to millions) of hashes per second. Argon2 was designed
to withstand such attacks.

This implementation uses the default work factors used in the argon2
command line client, but the resulting hashes are stored in a way that
would allow retroactive changes to these values, or even exposing them
as configuration in the module.

Ryan Tandy authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

init.c: align mi_dbenv_flags and flags with mdb_dbi_open, which declares
flags as unsigned int.

search.c: align mi_rtxn_size with ARG_UINT; adjust ww_ctx.nentries to
silence a warning about signed/unsigned comparison.

config.c: parse checkpoint config more carefully. Reject negative or
unreasonably large values for kbytes and minutes. Ensure both values are
parsed successfully before making any changes.

Fixes a compilation failure under MinGW, where stdint.h types are not
implicitly pulled in by other headers.

Ryan Tandy authored 5 years ago and Quanah Gibson-Mount committed 4 years ago

MinGW targets do not have the <sys/socket.h> header. The configure check
would conclude that there is no socklen_t type, resulting in portable.h
containing its own definition of socklen_t, which would later conflict
with the actual definition in <ws2tcpip.h>.

Add <ws2tcpip.h> to the configure check for socklen_t, so that the
defined type is correctly detected.

Howard Chu authored 4 years ago and Quanah Gibson-Mount committed 4 years ago

Always retry ldap_int_tls_connect() if it didn't complete,
regardless of blocking or non-blocking socket. Code from
ITS#7428 was wrong to only retry for async.