We have never documented our use of assert, so can't expect
builders to do the right thing.
This reverts commit c5b4cd67.

This reverts commit d65d34cc.
This reverts commit 2cf4758d.

Ryan Tandy authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

config_fp_parse_line processes backslash escapes. When existing rewrite
rules were reloaded while inserting a new rule, this caused backslashes
to be lost from every rule except the most recently inserted one.
config_parse_ldif performs similar splitting, but leaves backslashes
alone.

Ryan Tandy authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

Reserve #else for actual fallback cases.

Luca Bruno authored 10 years ago and Quanah Gibson-Mount committed 9 years ago

OpenLDAP can be configured to be either built with OpenSSL or
GnuTLS. This commit adds support for building pw-pbkbdf2 module
without OpenSSL, by using PBKDF2 crypto primitives provided by
libnettle.
Closes hamano/openldap-pbkdf2#2

Signed-off-by: Luca Bruno <luca.bruno@rocket-internet.de>

Luca Bruno authored 10 years ago and Quanah Gibson-Mount committed 9 years ago

Fixed asprintf return value check, in order to properly catch
error conditions. This has been caught by clang -Wtautological-compare:

pw-pbkdf2.c:132:17: warning: comparison of unsigned expression < 0 is always false
        if(msg->bv_len < 0){
           ~~~~~~~~~~~ ^ ~

Signed-off-by: Luca Bruno <luca.bruno@rocket-internet.de>

Howard Chu authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

Dynamic startup was failing

Howard Chu authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

This appears to be cruft leftover from rev e8c58b4e

Ryan Tandy authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

If dds is present early in the overlay stack, the modify ops from
dds_expire can trigger other overlays before they have initialized.
Avoid that by delaying the first expiry until startup has finished.

Howard Chu authored 9 years ago and Quanah Gibson-Mount committed 9 years ago

Limit the number of pwdFailureTime stamps to record, regardless
of lockout settings.