Ryan Tandy authored 5 years ago and Quanah Gibson-Mount committed 5 years ago

This reverts commits a956f759 ("Add (not
yet used) ICU detection") and 1cf5838e
("detect ICU and link it into slapd(8)").

Ondřej Kuzník authored 5 years ago and Quanah Gibson-Mount committed 5 years ago

Long term, overlay callbacks should not be running in tool mode at all.

Howard Chu authored 5 years ago and Quanah Gibson-Mount committed 5 years ago

If a txn is aborted in id2entry_put, attribute index mappings
added during that txn must also be dropped from memory.

Howard Chu authored 5 years ago and Quanah Gibson-Mount committed 5 years ago

And additional debug code for tracking errant close()s

Ryan Tandy authored 5 years ago and Quanah Gibson-Mount committed 5 years ago

Since GnuTLS moved to implicit initialization on library load, calling
this function deinitializes GnuTLS and then re-initializes it.

When GnuTLS uses /dev/urandom as an entropy source (getrandom() not
available, or older versions of GnuTLS), and the application closed all
file descriptors at startup, this could result in GnuTLS opening
/dev/urandom over one of the application's file descriptors when
re-initialized.

Additionally, the custom mutex functions are never reset, so if libldap
is unloaded (for example via dlclose()) after calling this, its code may
be unmapped and the application could crash when GnuTLS calls the mutex
functions.

On typical systems, GnuTLS system mutexes are probably the same as what
libldap uses anyway.