Changes prompted by Terry's patches

servers/slapd/connection.c

@@ -203,11 +203,11 @@ connection_activity(
 
 	pthread_attr_init( &attr );
 	pthread_attr_setdetachstate( &attr, PTHREAD_CREATE_DETACHED );
-#ifdef PTHREAD_MUTEX_INITIALIZER
-	/*
+#ifndef THREAD_MIT_PTHREADS
+	/* POSIX_THREADS or compatible
 	 * This is a draft 10 or standard pthreads implementation
 	 */
-	if ( pthread_create( &arg->co_op->o_tid, attr,
+	if ( pthread_create( &arg->co_op->o_tid, &attr,
 	    (void *) connection_operation, (void *) arg ) != 0 ) {
 		Debug( LDAP_DEBUG_ANY, "pthread_create failed\n", 0, 0, 0 );
 	} else {
@@ -215,11 +215,11 @@ connection_activity(
 		active_threads++;
 		pthread_mutex_unlock( &active_threads_mutex );
 	}
-#else	/* !PTHREAD_MUTEX_INITIALIZER*/
+#else	/* !THREAD_MIT_PTHREAD */
 	/*
 	 * This is a draft 4 or earlier pthreads implementation
 	 */
-	if ( pthread_create( &arg->co_op->o_tid, &attr,
+	if ( pthread_create( &arg->co_op->o_tid, attr,
 	    (void *) connection_operation, (void *) arg ) != 0 ) {
 		Debug( LDAP_DEBUG_ANY, "pthread_create failed\n", 0, 0, 0 );
 	} else {
@@ -227,6 +227,6 @@ connection_activity(
 		active_threads++;
 		pthread_mutex_unlock( &active_threads_mutex );
 	}
-#endif	/* !PTHREAD_MUTEX_INITIALIZER*/
+#endif	/* !THREAD_MIT_PTHREAD */
 	pthread_attr_destroy( &attr );
 }

servers/slapd/main.c

@@ -185,27 +185,27 @@ main( argc, argv )
 		pthread_attr_init( &attr );
 		pthread_attr_setdetachstate( &attr, PTHREAD_CREATE_DETACHED );
 
-#ifdef PTHREAD_MUTEX_INITIALIZER
-		/*
+#ifndef THREAD_MIT_PTHREADS
+		/* POSIX_THREADS or compatible
 		 * This is a draft 10 or standard pthreads implementation
 		 */
-		if ( pthread_create( &listener_tid, attr, (void *) slapd_daemon,
+		if ( pthread_create( &listener_tid, &attr, (void *) slapd_daemon,
 		    (void *) port ) != 0 ) {
 			Debug( LDAP_DEBUG_ANY,
 			    "listener pthread_create failed\n", 0, 0, 0 );
 			exit( 1 );
 		}
-#else	/* !PTHREAD_MUTEX_INITIALIZER */
+#else	/* !THREAD_MIT_PTHREADS */
 		/*
 		 * This is a draft 4 or earlier pthreads implementation
 		 */
-		if ( pthread_create( &listener_tid, &attr, (void *) slapd_daemon,
+		if ( pthread_create( &listener_tid, attr, (void *) slapd_daemon,
 		    (void *) port ) != 0 ) {
 			Debug( LDAP_DEBUG_ANY,
 			    "listener pthread_create failed\n", 0, 0, 0 );
 			exit( 1 );
 		}
-#endif	/* !PTHREAD_MUTEX_INITIALIZER */
+#endif	/* !THREAD_MIT_PTHREADS */
 		pthread_attr_destroy( &attr );
 		pthread_join( listener_tid, (void *) &status );
 		pthread_exit( 0 );

servers/slurpd/replica.c

@@ -59,29 +59,29 @@ start_replica_thread(
     pthread_attr_init( &attr );
     pthread_attr_setdetachstate( &attr, PTHREAD_CREATE_DETACHED );
 
-#ifdef PTHREAD_MUTEX_INITIALIZER
-    /*
+#ifndef THREAD_MIT_PTHREADS
+    /* POSIX_THREADS or compatible
      * This is a draft 10 or standard pthreads implementation
      */
-    if ( pthread_create( &(ri->ri_tid), attr, (void *) replicate,
+    if ( pthread_create( &(ri->ri_tid), &attr, (void *) replicate,
 	    (void *) ri ) != 0 ) {
 	Debug( LDAP_DEBUG_ANY, "replica \"%s:%d\" pthread_create failed\n",
 		ri->ri_hostname, ri->ri_port, 0 );
 	pthread_attr_destroy( &attr );
 	return -1;
     }
-#else	/* !PTHREAD_MUTEX_INITIALIZER */
+#else	/* !THREAD_MIT_PTHREADS */
     /*
      * This is a draft 4 or earlier pthreads implementation
      */
-    if ( pthread_create( &(ri->ri_tid), &attr, (void *) replicate,
+    if ( pthread_create( &(ri->ri_tid), attr, (void *) replicate,
 	    (void *) ri ) != 0 ) {
 	Debug( LDAP_DEBUG_ANY, "replica \"%s:%d\" pthread_create failed\n",
 		ri->ri_hostname, ri->ri_port, 0 );
 	pthread_attr_destroy( &attr );
 	return -1;
     }
-#endif	/* !PTHREAD_MUTEX_INITIALIZER */
+#endif	/* !THREAD_MIT_PTHREADS */
     pthread_attr_destroy( &attr );
     return 0;
 }