Connor Smith authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

Use #elif defined(...) for HAVE_WINSOCK and MACOS. All other instances
of these macros use #ifdef or similar. A compiler may warn about them
not being defined.

In libraries/liblber/sockbuf.c, (DOS && PCNFS) and (DOS && NCSA) were
replaced with HAVE_PCNFS and HAVE_NCSA, respectively. It seems logical
to do the same at the only remaining occurrence of DOS, PCNFS, and NCSA.

Use #if HARDCODE_DATA consistently, replacing two instances of #ifdef.
HARDCODE_DATA is always defined, and this way you can set HARDCODE_DATA
to 0 and have it work, rather than it going down the wrong branch and
failing in these two cases.

Howard Chu authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

Git doesn't recreate empty directories, make it explicitly

Howard Chu authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

Was broken if only dynamic lists were configured, and not groups. Optional config URIs were being ignored. Don't prevent returning dynamic lists if dynamic groups were part of search.

Howard Chu authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

Create them when running the test script instead.

Thomas Daniels authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

The options -h and -p got removed from client tools in commit
66af4cfd. However, they were still
present in the options[] array in several client tools source files. So,
if one of those tools got executed with -h or -p followed by a value,
this lead to the error "unrecognized option -", without mentioning
which option was problematic. Removing 'h' and 'p' from options[] fixes
this.

Howard Chu authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

memory alloc'd by bvarray_dup must be freed by bvarray_free, not regular free.

Mike Hommey authored 3 years ago and Howard Chu committed 2 years ago

ITS#9919 - Mark infrequently used functions as cold rather than manually putting them in a separate section

Mike Hommey authored 5 years ago and Howard Chu committed 2 years ago

It also contains the cacheflush function declaration.

Howard Chu authored 2 years ago and Quanah Gibson-Mount committed 2 years ago

Avoid unnecessary strdup in IPv6 addr parsing, check for strdup
failure when dup'ing scheme.

Code present since 2000, 8da110a9