ITS#9327 - Fix stripping when cross-compiling

Probably-Signed-off-by: Dave Bender bender@benegon.com

[yann.morin.1998@free.fr: patch was made by Dave, but he forgot his SoB line, so I added it]

Signed-off-by: "Yann E. MORIN" yann.morin.1998@free.fr

[Retrieved from: https://git.buildroot.net/buildroot/tree/package/openldap/0001-fix_cross_strip.patch]

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

changed the description

Hello,

Please read https://www.openldap.org/devel/contributing.html

Hello,

I just want to re-iterate that if you would like this MR to be looked at, you need to follow the proper procedure for contributing, as detailed at https://www.openldap.org/devel/contributing.html

Specifically in this case, there is no referenced issue from our issue tracker and there is no IPR statement as required for consideration.

Thanks!

Closing this MR due to lack of response, 3rd party submission, lack of following documented procedures.

closed

Hello Quanah, All!

Sorry for being late at the party! :-)

This patch originates from the Buildroot project, and it is our policy that we want to push our patches upstream, which Fabrice took on him to do with that one.

This patch has a proper assignment trail, with the usual "signed-off-by" tags (aka the DCO) like are used in the Linux kernel:

• Dave, initial author who submitted the patch to the Buildroot project
• I, Yann, who modified the patch
• Fabrice, who eventually took it from the Buildroot project and submitted here.

As for the licensing, we have a clear position in the Buildroot project, that the patches submitted to Buildroot are under the upstream licenses.

All of the above combined makes it fully legit for Fabrice to submit here a patch that he did not author. The only nit here, maybe, is that Fabrice should probably have had the git-author field be Dave, not himself, though.

This patch also only touches the build files. Of course the license for those is also important; still, the changes are trivial enough: there are only 6 new non-empty lines, and the other changes modify existing lines. As such, I understand they do fall below the "significant blocks of new code (10 lines or greater)" threshold defined in the contribution guidelines and thus do not require any further licensing notice.

Thanks.

Regards, Yann E. MORIN.

Hi Yann,

Again, for this request to be considered, you must follow the process outlined in https://www.openldap.org/devel/contributing.html

The very first step is to file an issue in our issue tracker.

All discussion about licensing and rights must be in that issue in the issue tracker.

Regards, Quanah

I opened an issue here: https://bugs.openldap.org/show_bug.cgi?id=9327

Thanks Fabrice. Can you put in something similar to what Yann noted about the build root rights assignments into the issue so it's on record there?

Additionally, this merge request would need to be updated to reference the filed issue as well. See the commit history for examples.

Regards, Quanah

changed title from Fix stripping when cross-compiling to ITS#9327 - Fix stripping when cross-compiling

reopened

Done

Great, tyvm!

Hi, the first part of this patches software from GNU, specifically shtool. We generally don't like to patch 3rd party software. Have you filed a bug report with GNU about this, as documented on the shtool website?

https://www.gnu.org/software/shtool/

shtool didn't had any release since 12 years so I don't think that opening a bug will really help us ...

That's really not a reason to not file a bug report. Plenty of GNU tools take years to iterate to a new release, and that's only going to continue if people fail to report bugs they find...

approved this merge request

added 34 commits

• 97e86bdb...5aa7e0f6 - 33 commits from branch openldap:master
• 8df03b43 - ITS#9327 - Fix stripping when cross-compiling

Compare with previous version

enabled an automatic merge when the pipeline for 8df03b43 succeeds

merged