Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O OpenLDAP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Bugzilla
    • Bugzilla
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • openldap
  • OpenLDAP
  • Merge requests
  • !106

ITS#9307: Make --enable-<option>=mod require --enable-modules

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ryan Tandy requested to merge ryan/openldap:its9307 into master Aug 04, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

Regression introduced by !46 (merged)/ITS#8224: configure fails with an unhelpful error message when configuring with --enable-<option>=mod but not --enable-modules.

This MR provides a more specific message in this case, makes it an error for both backends and overlays, and removes the automatic fallback to static.

Alternate approach would be to simply fix the regression and restore the RE24 behaviour. I am fine with either; feedback is welcome.

RE24:

./configure --enable-backends=mod
[...]
configure: WARNING: building static bdb backend

RE25:

./configure --enable-backends=mod
[...]
checking configure arguments... configure: error: slapd requires a backend

this branch:

./configure --enable-backends=mod
[...]
checking configure arguments... configure: error: --enable-backends=mod requires --enable-modules
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: its9307