Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O OpenLDAP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • openldap
  • OpenLDAP
  • Merge requests
  • !23

ITS#7878 Replace uint32_t with unsigned in back-mdb

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ryan Tandy requested to merge ryan/openldap:its7878 into master Apr 03, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 4

This fixes a compilation failure under MinGW, where stdint.h types are not implicitly pulled in by other headers. The quick fix is to #include <stdint.h>, however upon inspecting the types and their uses, it looked like using the fixed-size types is actually unnecessary. Tested on Linux (Debian 9) and MinGW (MSYS2).

init.c: align mi_dbenv_flags and flags with mdb_dbi_open, which declares flags as unsigned int.

search.c: align mi_rtxn_size with ARG_UINT, which assigns an unsigned int; also change ww_ctx.nentries to silence a warning about signed/unsigned comparison.

config.c: parse checkpoint config more carefully. Reject negative or unreasonably large values for kbytes and minutes (previously, negative or large values were just reinterpreted as uint32_t). Ensure both values are parsed successfully before making any changes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: its7878