Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
O
OpenLDAP
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
orbea -
OpenLDAP
Commits
c82dcab9
Commit
c82dcab9
authored
11 years ago
by
Howard Chu
Browse files
Options
Downloads
Patches
Plain Diff
ITS#7720 don't do ptr arithmetic on void *s
parent
9689f208
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
servers/slapd/back-mdb/dn2id.c
+6
-6
6 additions, 6 deletions
servers/slapd/back-mdb/dn2id.c
servers/slapd/back-mdb/tools.c
+2
-2
2 additions, 2 deletions
servers/slapd/back-mdb/tools.c
with
8 additions
and
8 deletions
servers/slapd/back-mdb/dn2id.c
+
6
−
6
View file @
c82dcab9
...
...
@@ -165,7 +165,7 @@ mdb_dn2id_add(
rc
=
mdb_cursor_get
(
mcp
,
&
key
,
&
data
,
MDB_SET
);
if
(
!
rc
)
{
char
*
p2
;
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
&
nid
,
ptr
,
sizeof
(
ID
));
/* Get parent's node under grandparent */
d
=
data
.
mv_data
;
...
...
@@ -178,7 +178,7 @@ mdb_dn2id_add(
op
->
o_tmpfree
(
p2
,
op
->
o_tmpmemctx
);
if
(
!
rc
)
{
/* Get parent's subtree count */
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
&
subs
,
ptr
,
sizeof
(
ID
));
subs
+=
nsubs
;
p2
=
op
->
o_tmpalloc
(
data
.
mv_size
,
op
->
o_tmpmemctx
);
...
...
@@ -246,7 +246,7 @@ mdb_dn2id_delete(
char
*
p2
;
diskNode
*
d
;
int
rlen
;
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
&
nid
,
ptr
,
sizeof
(
ID
));
/* Get parent's node under grandparent */
d
=
data
.
mv_data
;
...
...
@@ -259,7 +259,7 @@ mdb_dn2id_delete(
op
->
o_tmpfree
(
p2
,
op
->
o_tmpmemctx
);
if
(
!
rc
)
{
/* Get parent's subtree count */
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
&
subs
,
ptr
,
sizeof
(
ID
));
subs
-=
nsubs
;
p2
=
op
->
o_tmpalloc
(
data
.
mv_size
,
op
->
o_tmpmemctx
);
...
...
@@ -399,7 +399,7 @@ mdb_dn2id(
*
id
=
nid
;
/* return subtree count if requested */
if
(
!
rc
&&
nsubs
)
{
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
nsubs
,
ptr
,
sizeof
(
ID
));
}
if
(
!
mc
)
...
...
@@ -795,7 +795,7 @@ mdb_dn2id_walk(
/* Get next sibling */
rc
=
mdb_cursor_get
(
isc
->
mc
,
&
key
,
&
data
,
MDB_NEXT_DUP
);
if
(
!
rc
)
{
ptr
=
data
.
mv_data
+
data
.
mv_size
-
2
*
sizeof
(
ID
);
ptr
=
(
char
*
)
data
.
mv_data
+
data
.
mv_size
-
2
*
sizeof
(
ID
);
d
=
data
.
mv_data
;
memcpy
(
&
isc
->
id
,
ptr
,
sizeof
(
ID
));
...
...
This diff is collapsed.
Click to expand it.
servers/slapd/back-mdb/tools.c
+
2
−
2
View file @
c82dcab9
...
...
@@ -1421,7 +1421,7 @@ mdb_dn2id_upgrade( BackendDB *be ) {
if
(
dkids
>
1
)
{
rc
=
mdb_cursor_get
(
mc
,
&
key
,
&
data
,
MDB_NEXT_DUP
);
down:
ptr
=
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
ptr
=
(
unsigned
char
*
)
data
.
mv_data
+
data
.
mv_size
-
sizeof
(
ID
);
memcpy
(
&
id
,
ptr
,
sizeof
(
ID
));
depth
++
;
memcpy
(
stack
[
depth
].
rdn
,
data
.
mv_data
,
data
.
mv_size
);
...
...
@@ -1447,7 +1447,7 @@ pop:
goto
leave
;
}
data
.
mv_data
=
stack
[
depth
].
rdn
;
ptr
=
data
.
mv_data
+
data
.
mv_size
;
ptr
=
(
unsigned
char
*
)
data
.
mv_data
+
data
.
mv_size
;
memcpy
(
ptr
,
&
num
[
depth
],
sizeof
(
ID
));
data
.
mv_size
+=
sizeof
(
ID
);
rc
=
mdb_cursor_del
(
mc
,
0
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment