Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Compile with -DUSE_VALGRIND. It will attempt to keep Valgrind
informed of our memory allocations. Frees are trickier since they
may be deferred indefinitely.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Store a tail only in freed blocks.  (Alignment ensures there will
be room.)  Put the freed mark in next block's head.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

ctx==NULL code.  Add enum No_sl_malloc to avoid #ifdef SLAP_NO_SL_MALLOC.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Ensure Align >= sizeof(ber_len_t), to clarify the code's requirements.
Rearrange a slap_sl_malloc() branch to factor out ch_malloc fallbacks.
Fix range check (ptr+size >= endptr) -> (size >= endptr-ptr).  Fix debug msg.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Check count*size overflow. Omit slap_sl_malloc failure check, it cannot fail.

slap_sl_malloc could return failure. Exit instead, like the rest of sl_malloc.
Since we increase size, reduce it before Debug() and/or fallback to ch_malloc.
Debug() before exit() on failure.  Tweak debug formats and a comment.

Conflicts:

	servers/slapd/sl_malloc.c

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Move thread/nothread code to macros SET_MEMCTX()/GET_MEMCTX().
Rename some thread/memory contexts 'ctx' to thrctx/memctx to avoid confusion.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Preserve 2*int alignment on hosts where sizeof(int) == sizeof(ber_len_t).
If realloc of last block falls back to ch_malloc, free last block properly.
Fix range check (ptr + size < endptr) --> (size < endptr - ptr).

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Also use -Align instead of ~pad: Valid also for non-twos complement.

Hallvard Furuseth authored 15 years ago and Quanah Gibson-Mount committed 13 years ago

Bugfix: Switching implementation stack<->pool on an old context could
        crash or leak, it ran the wrong implementation's cleanup code.
Cleanup:  Factor out identical stack/pool code.  Call
          slap_sl_mem_destroy(NULL,) instead of copying its pool code.
API change: slap_sl_mem_destroy(key=NULL,) gets a new meaning.  Does
            not affect current OpenLDAP code, it never passed NULL.

Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Replaces commit 8eecc9a0

Hallvard Furuseth authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

slap_send_search_entry(), slap_send_search_reference(): Never skip
the cleanup code.  Sending an entry did on sizeLimitExceeded/busy.
Sending a ref dropped rs_flush_entry() on error.

Ralf Haferkamp authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Seems simpler this way. No need for a back-config specific
bi_access_allowed() handler.

Ralf Haferkamp authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

more for ITS#7066

Ralf Haferkamp authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Dynamically adding ACL for cn=config didn't work correctly, when no
ACLs where present for that database upon startup. Delete the last
ACL from the DB could also lead to unexpected results.

Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Bug was caused by postalAddressNormalize sending 0-length values
to UTF8StringNormalize.

Howard Chu authored 13 years ago and Quanah Gibson-Mount committed 13 years ago

Detected by valgrind