Howard Chu authored 11 years ago and Quanah Gibson-Mount committed 11 years ago

If multiple ops used the same opinfo the refcount wasn't being decremented

Page leak, mdb_page_alloc(). On error, don't shorten me_pghead.
Memleak, mdb_ovpage_free(). Free page or keep it in dirty_list.
Bad MIDL, mdb_midl_need(). Fix midl[-1] (allocated size).

Catch I/O errors. Do nothing between OS call failure and ErrCode().
Do not use errno after non-OS-errors like write() >= 0, which could
give a failure return of success (errno 0) or some irrelevant error
code.  Drop seek calls, use pwrite/pread/Windows OVERLAPPED offset.

Don't put a 64-bit filesize in a 32-bit int before shifting
down.  Always pass &sizehi to SetFilePointer->maxsize, so
sizelo not is treated a signed distance.  Hide unused vars
when _WIN32.  Reinitialize OVERLAPPED before reuse.

Grow midls earlier in order to catch errors earlier.  Use
mdb_midl_need() instead of mdb_midl_grow(), then mdb_midl_xappend()
needs no error checks. Factor out mdb_midl_append_range().

mdb_page_malloc(): Take a txn arg instead of a cursor.

Split out mdb_dpage_free(), mdb_page_flush() and clean up.

Merge if() branches. Restore retry=500 when MDB_PARANOID, for clarity.

MDB_env.me_pghead: Don't free it when empty. mdb_ovpage_free()
needs it, but cannot allocate it.
mdb_midl_alloc(): Fill in length=0.
mdb_page_alloc(): Also Skip freeDB if txnid<3, instead of <4,
and consistently DPRINTF consumed IDLs.

Landry Breuil authored 11 years ago and Quanah Gibson-Mount committed 11 years ago

Do not use lvals[], lnvals[] out of scope.

Committing a nested txn lost the MDB_TXN_DIRTY flag
in the parent, unless the child had set it too.

When copying, round up/down to aligned sizes. Skip the unused portion,
this was not done when touching a page dirty in the parent txn.
No other change in behavior.

Simplify mdb_page_touch(), including: Drop test m3==mc, the condition
is caught below. Don't "modify" the parent's pgno into the same pgno,
when a nested txn copies a parent's page into its freelist.

The tracking code should not change the current cursor.
It did when that was a C_SUB cursor, which should not be
checked against the tracked cursors but their xcursors.

However, do not bother to skip the tracking code for the
current cursor when it would not change that cursor anyway.

Do not binary-search dirty_list, it is unsorted when MDB_WRITEMAP.
Catch errors. In nested txns, put the page in mt_free_pgs after
all since pages dirty in a parent txn would add complexities.

MDB_NEXT was fine before, duh.

Split up saving me_pghead, to make me_pgfree unneeded. Also mf_pghead
is now a midl. Needed after e7f6767e
("Return fresh overflow pages to current pghead").
Tweak MDB_DEBUG freelist output, make it ascending.

And remove them from the current dirty list.

Update the subDB cursor, don't invalidate it

Allow writing backup to an already opened file handle, for piping
to tar/gzip/ssh/whatever.