Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O OpenLDAP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • openldap
  • OpenLDAP
  • Merge requests
  • !197

ITS#9363 Zero out value on config delete

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Kuzník requested to merge ondra/openldap:its9363 into master Oct 30, 2020
  • Overview 6
  • Commits 4
  • Pipelines 6
  • Changes 5

This lets back-config reset values for non-magic ARG_TYPES values to zero.

There are 89 cases of this across openldap+contrib, most of them are ok (default is 0/NULL or the value is a MUST), the following have a non-zero default and would be affected:

  • back-sql/ndb fields
  • index_substr_any_*
  • localSSF
  • sockbuf_max_incoming*
  • rtxnsize (in back-mdb)
  • sssvlv-maxkeys and sssvlv-maxperconn

All of the above could be fixed by adding a default parameter in the config table, maybe dropping the notify field there while we're at it, since it's never been implemented. That's what I intend to do here in the next version of this MR.

Edited Oct 30, 2020 by Ondřej Kuzník
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: its9363