Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Remove assert. This is merely a cache of parent DNs, failure to
insert doesn't affect outcome.

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

dn2id.c:
  + assertion for mdb_id2l_insert() result;
  - unnecessary assignment;

search.c:
  - unused variable 'first';
  + range-check for mdb_idl_search() result;

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Detaching a syncops record from op-list conditionally,
only when it was freed by syncprov_free_syncop.

The syncprov_free_syncop() and syncprov_drop_psearch() now
returns a flag, which is nonzero if the given syncops was freed.

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Mutex must be held even for a read-access of a cookie state,
as there may be a race with write in other thread.

Leonid Yuriev authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

heap corruption due to returning a reference to a local variable

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Only free when cleaning up operation controls, not response controls.
(This only makes a difference on search requests, which may have
multiple responses with the same set of controls.)

Howard Chu authored 10 years ago and Quanah Gibson-Mount committed 10 years ago

Make sure ntags isn't incremented if we're skippnig the tag