Jan Vcelak authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

The buffer allocated for reading password file has to be initialized
with zeros, or we need to append zero at the end of the file. Otherwise
we might read unitialized memory and consider it to be a password.

Jan Vcelak authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Prior to this patch, if TLS_CACERTDIR was set to Mozilla NSS certificate
database and TLS_CACERT was set to a PEM bundle file with CA
certificates, the PEM file content was not loaded.

With this patch and the same settings, OpenLDAP can verify certificates
which are signed by CAs stored both in certdb and PEM bundle file.

Frederik Deweerdt authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Not protecting the accesses to ldap_int_hostname could lead to a double
free.

Prefix ID, NOID, ID2, IDL, ID2L with 'MDB_'.
Also drop bdb from file description.

Put one call in #if MDB_DEBUG. Move DPRINTF(Using meta page #) there.

Define MDB_FDATASYNC() instead of redefining fdatasync().

If the database is opened with MDB_RDONLY or MDB_NOSYNC,
instead use the same file descriptor for me_mfd and me_fd.

Also factor out Windows/Unix error handling after open.

Get txn->mt_txnid from the meta page instead.  Otherwise it
and txn->mt_toggle could become inconsistent, since read-only
txns fetched both from MDB_txbody without mutex proteciton.

Make DPRINTF usable in if-else.  Silence signed vs unsigned warning.

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Also add mdb_debug/mdb_debug_start to toggle debug output at runtime

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Was being fooled before because the newly malloc'd block had
the same address as the previously freed block.

Also add mdb_debug/mdb_debug_start to toggle debug output at runtime

Was being fooled before because the newly malloc'd block had
the same address as the previously freed block.

Howard Chu authored 12 years ago and Quanah Gibson-Mount committed 12 years ago

Should probably compare nsize to pg_size/4 instead...

Should probably compare nsize to pg_size/4 instead...